Repository navigation
Conversation
aleksandy
commented
Jan 21, 2026
aleksandy
commented
- use toAray(IntFunction) instead of toArray(T[])
- optimize JavaExtensions#remove()
- simplify JavaExtensions#pad()
- simplify JavaExtensions#join()
- use primitives instead of wrappers
- use pattern matching instead of explicit cast
- use String.valueOf() and toString() for the objects stringification instead of concatenation with empty string
|
@xael-fry, @asolntsev, could you review my PR? |
xael-fry
left a comment
xael-fry
left a comment
There was a problem hiding this comment.
The MR is so called "cleanup" but it contains refactors,, fixes and all all parts off the code and not on a given part.
Please split your work in different MR, you can also use the conventional commit to have better description of the scope of the modification apply to.
Thanks
|
I've updated the PR. Removed the replacement of Stack with Deque. The rest of the changes, in my opinion, are quite suitable for a cleanup. Old unused code was removed, some was rewritten using modern capabilities of the standard library and the language. |
|
@xael-fry, any news about PR? |
|
@xael-fry, do you still have any comments on this PR? Could you merge it? |
* simplify #pad() * simplify #join()
# Conflicts: # framework/src/play/server/StreamChunkAggregator.java
…nstead of concatenation with empty string
* optimize #bindParameters()
…es list in parameters
* use HexFormat instead of manual encoding to hex-string
|
Tick the box to add this pull request to the merge queue (same as
|
|
Conflicts are fixed. The branch is actualized up to master. |
|
Tick the box to add this pull request to the merge queue (same as
|
